fix(ng-update): avoid error if project has folder ending with style extension #18454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension Previously, we always queried for `.css` and `.scss` files in the whole workspace. We relied on `glob` for this, but did not disable folder matching. Hence, it could happen that in some cases the migration rule tried reading content from a directory (resulting in `EISDIR` error). Additionally, we always queried for files in the actual workspace root. This has downsides and is not correct because it could mean that stylesheets from other projects are accidentally read (in case of a monorepo for example). Fixes angular#18434.
devversion
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Feb 19, 2020
Previously, we always queried for `.css` and `.scss` files in the whole workspace. We relied on `glob` for this, but did not disable folder matching. Hence, it could happen that in some cases the migration rule tried reading content from a directory (resulting in `EISDIR` error). Additionally, we always queried for files in the actual workspace root. This has downsides and is not correct because it could mean that stylesheets from other projects are accidentally read (in case of a monorepo for example). Fixes #18434.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we always queried for
.cssand.scssfiles in the wholeworkspace. We relied on
globfor this, but did not disable foldermatching. Hence, it could happen that in some cases the migration rule
tried reading content from a directory (resulting in
EISDIRerror).Additionally, we always queried for files in the actual workspace root.
This has downsides and is not correct because it could mean that
stylesheets from other projects are accidentally read (in case of a
monorepo for example).
Fixes #18434.