Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidenav): not restoring focus to SVG elements #18614

Merged
merged 1 commit into from
Feb 26, 2020
Merged

fix(sidenav): not restoring focus to SVG elements #18614

merged 1 commit into from
Feb 26, 2020

Conversation

crisbeto
Copy link
Member

SVG nodes can be focusable, but they won't match instanceof HTMLElement so we never restore focus to them.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 25, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner February 25, 2020 20:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2020
@crisbeto
fix(sidenav): not restoring focus to SVG elements
9578006 
SVG nodes can be focusable, but they won't match `instanceof HTMLElement` so we never restore focus to them.
@crisbeto crisbeto force-pushed the sidenav-svg-focus-restore branch from 3222211 to 9578006 Compare February 25, 2020 20:44
mmalerba
mmalerba approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 25, 2020
@jelbourn jelbourn merged commit 99d3e12 into angular:master Feb 26, 2020
jelbourn pushed a commit that referenced this pull request Mar 3, 2020
@crisbeto @jelbourn
fix(sidenav): not restoring focus to SVG elements (#18614)
ed763f5 
SVG nodes can be focusable, but they won't match `instanceof HTMLElement` so we never restore focus to them.

(cherry picked from commit 99d3e12)
This was referenced Mar 11, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 27, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @jelbourn @googlebot