Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form-field): error when trying to lock label into position too early #18666

Merged
merged 1 commit into from
Mar 12, 2020
Merged

fix(form-field): error when trying to lock label into position too early #18666

merged 1 commit into from
Mar 12, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 1, 2020

Fixes an error that is thrown by the form field's _animateAndLockLabel if it's called before ngAfterViewInit. This can happen if an autocomplete receives focus too early.

Fixes #18663.

@crisbeto
fix(form-field): error when trying to lock label into position too early
72debcd 
Fixes an error that is thrown by the form field's `_animateAndLockLabel` if it's called before `ngAfterViewInit`. This can happen if an autocomplete receives focus too early.

Fixes angular#18663.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 1, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner March 1, 2020 07:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 2, 2020
@andrewseguin andrewseguin merged commit eb92de8 into angular:master Mar 12, 2020
andrewseguin pushed a commit that referenced this pull request Mar 12, 2020
@crisbeto @andrewseguin
fix(form-field): error when trying to lock label into position too ea…
6fd3e6c 
…rly (#18666)

Fixes an error that is thrown by the form field's `_animateAndLockLabel` if it's called before `ngAfterViewInit`. This can happen if an autocomplete receives focus too early.

Fixes #18663.

(cherry picked from commit eb92de8)
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check for undefined label in _animateAndLockLabel()
5 participants
@crisbeto @devversion @mmalerba @googlebot @andrewseguin