Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(focus-monitor): Add eventual detection mode option to focus monitor #18684

Merged
merged 10 commits into from
Mar 17, 2020
Merged

feat(focus-monitor): Add eventual detection mode option to focus monitor #18684

merged 10 commits into from
Mar 17, 2020
+125 −14

Conversation

nickwalther
Copy link
Contributor

Add a detection window option to FocusMonitor to allow users to increase the timeout for attributing previous user event types as focus event origins.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 3, 2020
@nickwalther nickwalther changed the title Focus monitor detection window perf(focus-monitor): Add detection window option Mar 3, 2020
@nickwalther nickwalther changed the title perf(focus-monitor): Add detection window option feat(focus-monitor): Add detection window option Mar 3, 2020
@nickwalther
Add a detection window option to FocusMonitor to allow users to incre…
4e28279 
…ase the timeout for attributing previous user event types as focus event origins.
@nickwalther nickwalther force-pushed the focus-monitor-detection-window branch from 673e05d to 4e28279 Compare March 6, 2020 00:36
@nickwalther nickwalther changed the title feat(focus-monitor): Add detection window option feat(focus-monitor): Add aggressive detection strategy option Mar 7, 2020
@nickwalther nickwalther changed the title feat(focus-monitor): Add aggressive detection strategy option feat(focus-monitor): Add eventual detection mode option to focus monitor Mar 11, 2020
@nickwalther nickwalther marked this pull request as ready for review March 11, 2020 06:57
@jelbourn jelbourn added G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release labels Mar 11, 2020
jelbourn
jelbourn approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 11, 2020
@mmalerba mmalerba merged commit b3a2c56 into angular:master Mar 17, 2020
@nickwalther nickwalther deleted the focus-monitor-detection-window branch March 17, 2020 21:25
@snyk-bot snyk-bot mentioned this pull request Mar 28, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickwalther @jelbourn @googlebot @mmalerba