Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdc-form-field): refresh notch width when toggling appearances #18776

Merged
merged 2 commits into from
Mar 12, 2020
Merged

fix(mdc-form-field): refresh notch width when toggling appearances #18776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe62e4e
fix(material-experimental/mdc-form-field): refresh notch width when t…
devversion Mar 10, 2020
1e56dd5
refactor(material/material-experimental): reduce specificity of texta…
devversion Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/material-experimental/mdc-form-field/_mdc-text-field-textarea-overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
@mixin _mat-mdc-text-field-textarea-overrides() {
// Ensures that textarea elements inside of the form-field have proper vertical spacing
// to account for the floating label. Also ensures that there is no vertical text overflow.
// TODO(devversion): remove extra specificity if we removed the ":not(outline-appearance)"
// selector from the structure overwrites. Blocked on material-components-web#5326.
.mat-mdc-form-field > .mat-mdc-text-field-wrapper .mat-mdc-form-field-infix
.mat-mdc-textarea-input {
resize: vertical;
box-sizing: border-box;
Expand Down
2 changes: 2 additions & 0 deletions src/material-experimental/mdc-form-field/directives/notched-outline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ export class MatFormFieldNotchedOutline implements AfterViewInit, OnChanges, OnD
// that we cannot extend from the "MDCNotchedOutline".
this._mdcNotchedOutline = MDCNotchedOutline.attachTo(this._elementRef.nativeElement);
}
// Initial sync in case state has been updated before view initialization.
this._syncNotchedOutlineState();
}

ngOnChanges() {
Expand Down