Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): chip list overriding chip disabled value #19228

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/material/chips/chip-list.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,28 @@ describe('MatChipList', () => {
expect(chips.toArray().every(chip => chip.disabled)).toBe(true);
}));

it('should preserve the disabled state of a chip if the list gets re-enabled', () => {
const chipArray = chips.toArray();

chipArray[2].disabled = true;
fixture.detectChanges();

expect(chips.toArray().map(chip => chip.disabled))
.toEqual([false, false, true, false, false]);

chipListInstance.disabled = true;
fixture.detectChanges();

expect(chips.toArray().map(chip => chip.disabled))
.toEqual([true, true, true, true, true]);

chipListInstance.disabled = false;
fixture.detectChanges();

expect(chips.toArray().map(chip => chip.disabled))
.toEqual([false, false, true, false, false]);
});

});

describe('with selected chips', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/material/chips/chip-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ export class MatChipList extends _MatChipListMixinBase implements MatFormFieldCo
private _syncChipsState() {
if (this.chips) {
this.chips.forEach(chip => {
chip.disabled = this._disabled;
chip._chipListDisabled = this._disabled;
chip._chipListMultiple = this.multiple;
});
}
Expand Down
23 changes: 16 additions & 7 deletions src/material/chips/chip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,13 @@ import {
import {
CanColor,
CanColorCtor,
CanDisable,
CanDisableCtor,
CanDisableRipple,
CanDisableRippleCtor,
HasTabIndex,
HasTabIndexCtor,
mixinTabIndex,
MAT_RIPPLE_GLOBAL_OPTIONS,
mixinColor,
mixinDisabled,
mixinDisableRipple,
RippleConfig,
RippleGlobalOptions,
Expand Down Expand Up @@ -71,12 +68,13 @@ export class MatChipSelectionChange {
// Boilerplate for applying mixins to MatChip.
/** @docs-private */
class MatChipBase {
disabled: boolean;
constructor(public _elementRef: ElementRef) {}
}

const _MatChipMixinBase: CanColorCtor & CanDisableRippleCtor & CanDisableCtor &
const _MatChipMixinBase: CanColorCtor & CanDisableRippleCtor &
HasTabIndexCtor & typeof MatChipBase =
mixinTabIndex(mixinColor(mixinDisableRipple(mixinDisabled(MatChipBase)), 'primary'), -1);
mixinTabIndex(mixinColor(mixinDisableRipple(MatChipBase), 'primary'), -1);

/**
* Dummy directive to add CSS class to chip avatar.
Expand All @@ -103,7 +101,7 @@ export class MatChipTrailingIcon {}
*/
@Directive({
selector: `mat-basic-chip, [mat-basic-chip], mat-chip, [mat-chip]`,
inputs: ['color', 'disabled', 'disableRipple', 'tabIndex'],
inputs: ['color', 'disableRipple', 'tabIndex'],
exportAs: 'matChip',
host: {
'class': 'mat-chip mat-focus-indicator',
Expand All @@ -124,7 +122,7 @@ export class MatChipTrailingIcon {}
},
})
export class MatChip extends _MatChipMixinBase implements FocusableOption, OnDestroy, CanColor,
CanDisable, CanDisableRipple, RippleTarget, HasTabIndex {
CanDisableRipple, RippleTarget, HasTabIndex {

/** Reference to the RippleRenderer for the chip. */
private _chipRipple: RippleRenderer;
Expand Down Expand Up @@ -164,6 +162,9 @@ export class MatChip extends _MatChipMixinBase implements FocusableOption, OnDes
/** Whether the chip list is in multi-selection mode. */
_chipListMultiple: boolean = false;

/** Whether the chip list as a whole is disabled. */
_chipListDisabled: boolean = false;

/** The chip avatar */
@ContentChild(MatChipAvatar) avatar: MatChipAvatar;

Expand Down Expand Up @@ -209,6 +210,14 @@ export class MatChip extends _MatChipMixinBase implements FocusableOption, OnDes
}
protected _selectable: boolean = true;

/** Whether the chip is disabled. */
@Input()
get disabled(): boolean { return this._chipListDisabled || this._disabled; }
set disabled(value: boolean) {
this._disabled = coerceBooleanProperty(value);
}
protected _disabled: boolean = false;

/**
* Determines whether or not the chip displays the remove styling and emits (removed) events.
*/
Expand Down
8 changes: 6 additions & 2 deletions tools/public_api_guard/material/chips.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
export declare const MAT_CHIPS_DEFAULT_OPTIONS: InjectionToken<MatChipsDefaultOptions>;

export declare class MatChip extends _MatChipMixinBase implements FocusableOption, OnDestroy, CanColor, CanDisable, CanDisableRipple, RippleTarget, HasTabIndex {
export declare class MatChip extends _MatChipMixinBase implements FocusableOption, OnDestroy, CanColor, CanDisableRipple, RippleTarget, HasTabIndex {
_animationsDisabled: boolean;
_chipListDisabled: boolean;
_chipListMultiple: boolean;
protected _disabled: boolean;
_elementRef: ElementRef<HTMLElement>;
_hasFocus: boolean;
readonly _onBlur: Subject<MatChipEvent>;
Expand All @@ -15,6 +17,8 @@ export declare class MatChip extends _MatChipMixinBase implements FocusableOptio
avatar: MatChipAvatar;
chipListSelectable: boolean;
readonly destroyed: EventEmitter<MatChipEvent>;
get disabled(): boolean;
set disabled(value: boolean);
get removable(): boolean;
set removable(value: boolean);
removeIcon: MatChipRemove;
Expand Down Expand Up @@ -46,7 +50,7 @@ export declare class MatChip extends _MatChipMixinBase implements FocusableOptio
static ngAcceptInputType_removable: BooleanInput;
static ngAcceptInputType_selectable: BooleanInput;
static ngAcceptInputType_selected: BooleanInput;
static ɵdir: i0.ɵɵDirectiveDefWithMeta<MatChip, "mat-basic-chip, [mat-basic-chip], mat-chip, [mat-chip]", ["matChip"], { "color": "color"; "disabled": "disabled"; "disableRipple": "disableRipple"; "tabIndex": "tabIndex"; "selected": "selected"; "value": "value"; "selectable": "selectable"; "removable": "removable"; }, { "selectionChange": "selectionChange"; "destroyed": "destroyed"; "removed": "removed"; }, ["avatar", "trailingIcon", "removeIcon"]>;
static ɵdir: i0.ɵɵDirectiveDefWithMeta<MatChip, "mat-basic-chip, [mat-basic-chip], mat-chip, [mat-chip]", ["matChip"], { "color": "color"; "disableRipple": "disableRipple"; "tabIndex": "tabIndex"; "selected": "selected"; "value": "value"; "selectable": "selectable"; "disabled": "disabled"; "removable": "removable"; }, { "selectionChange": "selectionChange"; "destroyed": "destroyed"; "removed": "removed"; }, ["avatar", "trailingIcon", "removeIcon"]>;
static ɵfac: i0.ɵɵFactoryDef<MatChip, [null, null, null, { optional: true; }, { optional: true; }, null, { attribute: "tabindex"; }, { optional: true; }]>;
}

Expand Down