fix(text-field): unable to undo/redo in autosized text field on firefox #19238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we're measuring the height of an autosized textarea, we apply a class that has `overflow: hidden`. The `overflow` declaration seems to hit a bug on Firefox that doesn't allow users to undo/redo what they've typed. These changes add a specific workaround for Firefox. Fixes angular#16629.
crisbeto
added
P2
googlebot
added
the
cla: yes
mmalerba
reviewed
May 5, 2020
| // because the measurements there don't seem to be affected by the `height: 0`, whereas on other | ||
| // browsers they are, e.g. Chrome detects longer text and IE does't resize back to normal. | ||
| // Identical issue report: https://bugzilla.mozilla.org/show_bug.cgi?id=448784 | ||
| textarea.cdk-textarea-autosize-measuring-firefox { |
There was a problem hiding this comment.
I think overflow:hidden was there because it prevented scrollbars from messing up the calculation. Have you confirmed if this is a problem on firefox now?
There was a problem hiding this comment.
It seemed to behave correctly when I was testing it out in the dev app. I was trying both the one that's on a plain textarea, as well as the one in the form field.
mmalerba
pushed a commit
that referenced
this pull request
May 15, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're measuring the height of an autosized textarea, we apply a class that has
overflow: hidden. Theoverflowdeclaration seems to hit a bug on Firefox that doesn't allow users to undo/redo what they've typed. These changes add a specific workaround for Firefox.Fixes #16629.