Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): focus trap not attached if autoFocus is disabled #19251

Merged
merged 1 commit into from
May 8, 2020
Merged

fix(dialog): focus trap not attached if autoFocus is disabled #19251

merged 1 commit into from
May 8, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 4, 2020

In #18826 some code was moved around, and as a result, the focus trap was being created lazily only when we interact with its API. The problem is that this means that focus trapping will be disabled if autoFocus was turned off.

Fixes #19246.

@crisbeto
fix(dialog): focus trap not attached if autoFocus is disabled
566f1fa 
In angular#18826 some code was moved around, and as a result, the focus trap was being created lazily only when we interact with its API. The problem is that this means that focus trapping will be disabled if `autoFocus` was turned off.

Fixes angular#19246.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels May 4, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner May 4, 2020 15:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 4, 2020
jelbourn
jelbourn approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 4, 2020
@jelbourn jelbourn merged commit 5bb81e8 into angular:master May 8, 2020
jelbourn pushed a commit that referenced this pull request May 8, 2020
@crisbeto @jelbourn
fix(dialog): focus trap not attached if autoFocus is disabled (#19251)
e61deb9 
In #18826 some code was moved around, and as a result, the focus trap was being created lazily only when we interact with its API. The problem is that this means that focus trapping will be disabled if `autoFocus` was turned off.

Fixes #19246.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatDialog): with 'autoFocus: false' lacks focus trap after angular/[email protected]/9.2.2
3 participants
@crisbeto @jelbourn @googlebot