Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mdc-list): add list-option template #19327

Merged
merged 5 commits into from
Jun 9, 2020
Merged

feat(mdc-list): add list-option template #19327

merged 5 commits into from
Jun 9, 2020

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented May 11, 2020 •
edited
Loading

No description provided.

@mmalerba mmalerba added blocked This issue is blocked by some external factor, such as a prerequisite PR merge safe target: patch This PR is targeted for the next patch release labels May 11, 2020
@mmalerba mmalerba requested a review from jelbourn May 11, 2020 23:50
@mmalerba mmalerba requested review from crisbeto, devversion and a team as code owners May 11, 2020 23:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 11, 2020
@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label May 13, 2020
@mmalerba
Copy link
Contributor Author

mmalerba commented Jun 4, 2020

Ok, I've cut down as much as possible on the use of <ng-template> and *ngIf, PTAL

jelbourn
jelbourn approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 9, 2020
@andrewseguin andrewseguin merged commit c865136 into angular:master Jun 9, 2020
andrewseguin pushed a commit that referenced this pull request Jun 9, 2020
@mmalerba @andrewseguin
feat(mdc-list): add list-option template (#19327)
75faddf 
* feat(material-expeirmental/mdc-list): add support for focus/hover states
and ripples

* add state styles

* add demo and stub implementation for mdc-based selection-list

* reduce the number of ng-template's needed in list-item and list-option

* address comments
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @googlebot @andrewseguin