Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(progress-spinner): create progress-spinner based on MDC Web #20048

Merged
merged 18 commits into from
Jul 31, 2020
Merged

feat(progress-spinner): create progress-spinner based on MDC Web #20048

merged 18 commits into from
Jul 31, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Jul 20, 2020

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2020
@annieyw annieyw force-pushed the mdc-progress-spinner branch 3 times, most recently from ca84a45 to bcac8f0 Compare July 21, 2020 23:22
@annieyw annieyw marked this pull request as ready for review July 22, 2020 16:52
@annieyw annieyw requested review from devversion and a team as code owners July 22, 2020 16:52
@crisbeto
Copy link
Member

One more thing: it doesn't look like the server-side rendering check was set up for the new component.

mmalerba
mmalerba reviewed Jul 23, 2020
View reviewed changes
jelbourn
jelbourn reviewed Jul 23, 2020
View reviewed changes
src/material-experimental/mdc-progress-spinner/progress-spinner.html
</div>
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the MDC spinner is so much more complicated than our existing one? I'm surprised that this has four SVGs when the current spinner uses just one (with two circle elements)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be because the MDC spinner supports 4 colors but I'm not sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four colors at the same time? It would be good to just check in with them to get some background so that we know why it's built this way

@annieyw annieyw force-pushed the mdc-progress-spinner branch from 1a7ef3e to 69605dc Compare July 24, 2020 19:30
jelbourn
jelbourn reviewed Jul 24, 2020
View reviewed changes
src/material-experimental/mdc-progress-spinner/progress-spinner.html
</div>
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four colors at the same time? It would be good to just check in with them to get some background so that we know why it's built this way

@annieyw annieyw force-pushed the mdc-progress-spinner branch from 5f6798b to d9592f5 Compare July 27, 2020 21:47
@annieyw annieyw force-pushed the mdc-progress-spinner branch from d9592f5 to de98adf Compare July 27, 2020 21:50
mmalerba
mmalerba approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm target: patch This PR is targeted for the next patch release labels Jul 28, 2020
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Jul 28, 2020
jelbourn
jelbourn approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- we can figure out more about the multiple svgs as we go

@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@jelbourn jelbourn merged commit 294b8ee into angular:master Jul 31, 2020
jelbourn pushed a commit that referenced this pull request Jul 31, 2020
@annieyw @jelbourn
prototype(progress-spinner): create prototype progress-spinner based …
f80c7d5 
…on MDC Web (#20048)

* add files for MDC-based MatProgressSpinner

* add demo of mdc-based MatProgressSpinner at localhost:4200/mdc-progress-spinner

* copy MDC DOM and add MDC styles

* set up MDC foundation for MDC-based MatProgressSpinner

* (wip) add adapter and fill in API

* copy over existing demo to MDC-based demo

* serverside rendering, refactor

* add tests (adapter class wip)

* remove separate class for MatSpinner

* add e2e tests

* add harness

* add user documantation README

* add codeowner, theme dep

* address CI failures

* export MatSpinner as const to avoid build error

* fix missing e2e import

* fix nits

* remove changes to _all-themes to keep PR merge-safe (add back in followup)

(cherry picked from commit 294b8ee)
@annieyw annieyw deleted the mdc-progress-spinner branch August 3, 2020 16:51
@annieyw annieyw mentioned this pull request Aug 3, 2020
Merged
@mmalerba mmalerba changed the title prototype(progress-spinner): create prototype progress-spinner based on MDC Web feat(progress-spinner): create prototype progress-spinner based on MDC Web Aug 26, 2020
@mmalerba mmalerba changed the title feat(progress-spinner): create prototype progress-spinner based on MDC Web feat(progress-spinner): create progress-spinner based on MDC Web Aug 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto left review comments

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annieyw @crisbeto @jelbourn @mmalerba @googlebot