Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): remove red shadow from invalid range inputs in Firefox #20489

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix(datepicker): remove red shadow from invalid range inputs in Firefox #20489

merged 1 commit into from
Sep 16, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 3, 2020

Firefox automatically adds a red box-shadow to invalid inputs. These changes remove it from the inner range inputs since their invalid state is shown through the mat-form-field.

Fixes #20483.

@crisbeto
fix(datepicker): remove red shadow from invalid range inputs in Firefox
19632fe 
Firefox automatically adds a red `box-shadow` to invalid inputs. These changes remove it from the inner range inputs since their invalid state is shown through the `mat-form-field`.

Fixes angular#20483.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 3, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner September 3, 2020 12:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2020
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 3, 2020
mmalerba
mmalerba approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit 50eca15 into angular:master Sep 16, 2020
wagnermaciel pushed a commit that referenced this pull request Sep 16, 2020
@crisbeto @wagnermaciel
fix(datepicker): remove red shadow from invalid range inputs in Firef…
bdc5aa3 
…ox (#20489)

Firefox automatically adds a red `box-shadow` to invalid inputs. These changes remove it from the inner range inputs since their invalid state is shown through the `mat-form-field`.

Fixes #20483.

(cherry picked from commit 50eca15)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datepicker - Firefox displaying red box-shadow when "required" attribute added to matEndDate input
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel