feat(cdk/scrolling): update CdkVirtualForOf to work with sets. #20594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
howardjing
force-pushed
the
cdk-scrolling-fix
branch
2 times, most recently
from
72b2761 to
3a0f4fa
Compare
crisbeto
reviewed
Sep 25, 2020
The previous usage of `Array.prototype.slice.call` does not handle `Set` objects appropriately (since a `Set` does not have a `length` property). Updated it to use `Array.from`. Fixes angular#20210.
howardjing
force-pushed
the
cdk-scrolling-fix
branch
from
3a0f4fa to
d6fbd46
Compare
|
Thanks for the review! I updated the commit message. I believe the current test make sure that the feature works -- is there anything additional you would like added? There's no corresponding virtual-for-of.spec.ts file, so the existing test seemed like the most appropriate one for me to add. |
crisbeto
approved these changes
Sep 27, 2020
crisbeto
added
action: merge
|
@crisbeto What's going on with CI here? |
|
Not sure, but it wasn't triggered for some reason. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous usage of
Array.prototype.slice.calldoes not handleSetobjects appropriately (since a
Setdoes not have alengthproperty).Updated it to use
Array.from.Fixes #20210.