fix(material-experimental/mdc-slide-toggle): align focus behavior with standard version #20772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
mdc-slide-toggle-focus-behavior
branch
from
dbcd32b to
b524dfc
Compare
…h standard version The focus behavior of the existing `mat-slide-toggle` was changed slightly after the MDC version was implemented. These changes align the behavior and add some missing tests.
crisbeto
force-pushed
the
mdc-slide-toggle-focus-behavior
branch
from
b524dfc to
03be7b7
Compare
annieyw
approved these changes
Oct 15, 2020
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 19, 2020
The changes from angular#20772 appear to have introduce a flaky test. These changes try to resolve it.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 19, 2020
The changes from angular#20772 appear to have introduce a flaky test. These changes try to resolve it.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus behavior of the existing
mat-slide-togglewas changed slightly after the MDC version was implemented. These changes align the behavior and add some missing tests.