Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/scrolling): update ScrollDispatcher to allow HTMLElement par… #21201

Merged
merged 1 commit into from
Jan 9, 2021
Merged

feat(cdk/scrolling): update ScrollDispatcher to allow HTMLElement par… #21201

merged 1 commit into from
Jan 9, 2021

Conversation

BobobUnicorn
Copy link
Collaborator

…ameters

Update ScrollDispatcher API to take elements of either ElementRef or HTMLElement. This is
to maintain consistency with newer APIs.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 2, 2020
crisbeto
crisbeto reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but you'll have to run yarn approve-api scrolling and commit the changed file for the CI to pass.

@dependabot @BobobUnicorn
feat(cdk/scrolling): update ScrollDispatcher to allow HTMLElement par…
ab546a5 
…ameters

Update ScrollDispatcher API to take elements of either ElementRef or HTMLElement. This is
to maintain consistency with newer APIs.
@BobobUnicorn BobobUnicorn force-pushed the scroll-dispatcher-htmlelement branch from 50901dc to ab546a5 Compare December 8, 2020 22:21
@BobobUnicorn BobobUnicorn requested a review from a team as a code owner December 8, 2020 22:21
crisbeto
crisbeto approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Dec 9, 2020
@BobobUnicorn
Copy link
Collaborator Author

@andrewseguin are you able to review this? Is there anything else I'd need to do?

@annieyw annieyw merged commit ddc2e23 into angular:master Jan 9, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@BobobUnicorn @dependabot @wagnermaciel
feat(cdk/scrolling): update ScrollDispatcher to allow HTMLElement par…
23633b7 
…ameters (angular#21201)

Update ScrollDispatcher API to take elements of either ElementRef or HTMLElement. This is
to maintain consistency with newer APIs.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobobUnicorn @crisbeto @annieyw