Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/stepper): setting invalid value for visibility #22254

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix(material/stepper): setting invalid value for visibility #22254

merged 1 commit into from
Mar 23, 2021

Conversation

VinitTomar
Copy link
Contributor

Setting empty string for visibility is an invalid css property value.
Which leads to error "Failed to execute 'animate' on 'Element' : Partial keyframes are not supported" in old browser.

Screenshot

@VinitTomar VinitTomar requested a review from mmalerba as a code owner March 17, 2021 04:26
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2021
@VinitTomar VinitTomar requested a review from crisbeto March 17, 2021 12:33
@popec
Copy link

popec commented Mar 18, 2021

It's an issue for us too.
image

@VinitTomar
fix(material/stepper): setting invalid value for visibility
a0e4a0f 
Setting empty string for visibility is an invalid css property value.
Which leads to error "Failed to execute 'animate' on 'Element' : Partial keyframes are not supported" in old browser.
mmalerba
mmalerba approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 18, 2021
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 21, 2021
@andrewseguin andrewseguin merged commit 6db0fa9 into angular:master Mar 23, 2021
andrewseguin pushed a commit that referenced this pull request Mar 23, 2021
@VinitTomar @andrewseguin
fix(material/stepper): setting invalid value for visibility (#22254)
3ead2cd 
Setting empty string for visibility is an invalid css property value.
Which leads to error "Failed to execute 'animate' on 'Element' : Partial keyframes are not supported" in old browser.

(cherry picked from commit 6db0fa9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Brandinga Brandinga Brandinga left review comments

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VinitTomar @popec @crisbeto @mmalerba @Brandinga @andrewseguin