Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google-maps): add clusterer click event #22345

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

crisbeto
Copy link
Member

Adds an event that emits when a cluster has been clicked.

Fixes #22020.

Adds an event that emits when a cluster has been clicked.

Fixes angular#22020.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Mar 25, 2021
@crisbeto crisbeto requested a review from a team as a code owner March 25, 2021 20:25
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 25, 2021
@@ -177,6 +177,10 @@ export class MapMarkerClusterer implements OnInit, AfterContentInit, OnChanges,
@Output()
clusteringend: Observable<void> = this._eventManager.getLazyEmitter<void>('clusteringend');

/** Emits when a cluster has been clicked. */
@Output()
clusterClick: Observable<Cluster> = this._eventManager.getLazyEmitter<Cluster>('click');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure about the correct name here. In other places we've been using the map prefix (e.g. mapClick on the marker), but in this case the user is clicking a cluster within the clusterer, not the map. I'm open to changing the name.

Copy link
Collaborator

@mbehrlich mbehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 25, 2021
@wagnermaciel wagnermaciel merged commit 9528120 into angular:master Mar 29, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add click output to clusterer
3 participants