Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/portal): not marked as attached when going through specific portal methods #22372

Merged
merged 1 commit into from
Apr 2, 2021
Merged

fix(cdk/portal): not marked as attached when going through specific portal methods #22372

merged 1 commit into from
Apr 2, 2021

Conversation

crisbeto
Copy link
Member

Fixes that the DomPortalOutlet.hasAttached doesn't return the correct information when the portal has been attached through the specific portal methods (e.g. attachComponentPortal, attachTemplatePortal).

Fixes #22370.

@crisbeto
fix(cdk/portal): not marked as attached when going through specific p…
4d8359b 
…ortal methods

Fixes that the `DomPortalOutlet.hasAttached` doesn't return the correct information when the portal has been attached through the specific portal methods (e.g. `attachComponentPortal`, `attachTemplatePortal`).

Fixes angular#22370.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 30, 2021
@crisbeto crisbeto requested a review from andrewseguin March 30, 2021 18:47
@crisbeto crisbeto requested a review from jelbourn as a code owner March 30, 2021 18:47
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 30, 2021
jelbourn
jelbourn approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm surprised we went this long without running into this

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 31, 2021
@annieyw annieyw merged commit 92af5f1 into angular:master Apr 2, 2021
annieyw pushed a commit that referenced this pull request Apr 2, 2021
@crisbeto @annieyw
fix(cdk/portal): not marked as attached when going through specific p…
f387ff6 
…ortal methods (#22372)

Fixes that the `DomPortalOutlet.hasAttached` doesn't return the correct information when the portal has been attached through the specific portal methods (e.g. `attachComponentPortal`, `attachTemplatePortal`).

Fixes #22370.

(cherry picked from commit 92af5f1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(DomPortalOutlet): hasAttached returns false after attachComponentPortal
3 participants
@crisbeto @jelbourn @annieyw