Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(material-experimental/mdc-progress-bar): remove wrapper element for progress bar #22441

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Apr 9, 2021

refactor progress bar to have same structure as progress spinner (without wrapper element)

related: #22429

@annieyw annieyw requested review from jelbourn and crisbeto April 9, 2021 01:10
@annieyw annieyw requested a review from andrewseguin as a code owner April 9, 2021 01:10
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 9, 2021
@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 9, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 9, 2021
@annieyw
Copy link
Contributor Author

annieyw commented Apr 9, 2021

Seems like the issue with the tests is that the original progress bar has a wrapper div around the different bars but as discussed in #22429 progress bar and progress spinner should have the same a11y setup. Any ideas on which we should prioritize? (align with original progress bar or have mdc progress bar/spinner have same a11y)

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. I think that we should keep the DOM as close to MDC as possible and update the tests to expect more than one root node inside the progress bar. I don't think that screen readers care whether it's one root node with aria-hidden or multiple siblings with aria-hidden.

@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Apr 9, 2021
@Splaktar Splaktar changed the title refactor(material-experimental/mdc-progress-bar): remove wrapper elem… refactor(material-experimental/mdc-progress-bar): remove wrapper element for progress bar Apr 19, 2021
@annieyw
Copy link
Contributor Author

annieyw commented Apr 20, 2021

Animations were still running with NoopAnimationsModule with the previous fix. Added some more specific selectors to disable animations (like in progress spinner)

@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 27, 2021
@andrewseguin andrewseguin merged commit acf1b86 into angular:master Apr 27, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants