-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(material-experimental/mdc-progress-bar): remove wrapper element for progress bar #22441
Conversation
Seems like the issue with the tests is that the original progress bar has a wrapper div around the different bars but as discussed in #22429 progress bar and progress spinner should have the same a11y setup. Any ideas on which we should prioritize? (align with original progress bar or have mdc progress bar/spinner have same a11y) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM. I think that we should keep the DOM as close to MDC as possible and update the tests to expect more than one root node inside the progress bar. I don't think that screen readers care whether it's one root node with aria-hidden
or multiple siblings with aria-hidden
.
…ent for progress bar
…er element for progress bar
…ors to disable animations in noop animation mode
Animations were still running with |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
refactor progress bar to have same structure as progress spinner (without wrapper element)
related: #22429