fix(material/datepicker): pass correct inject flags to injector #22665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a call to `Injector.get` in the date range input which is supposed to fall back to `null` if the value doesn't resolve, however we're missing the `Optional` flag. It works by accident at the moment, because the inject flags aren't actually being passed through by the framework. angular/angular#41592 is supposed to fix the framework issue, but their CI will break due to our usage. These changes fix our usage in order to unblock the framework PR.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
mmalerba
approved these changes
May 11, 2021
mmalerba
added
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
May 18, 2021
We have a call to `Injector.get` in the date range input which is supposed to fall back to `null` if the value doesn't resolve, however we're missing the `Optional` flag. It works by accident at the moment, because the inject flags aren't actually being passed through by the framework. angular/angular#41592 is supposed to fix the framework issue, but their CI will break due to our usage. These changes fix our usage in order to unblock the framework PR. (cherry picked from commit 7367823)
14 tasks
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 8, 2021
Fixes a few more cases like angular#22665 where we were injecting something optionally, but we weren't passing the optional injector flag.
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 10, 2021
Fixes a few more cases like #22665 where we were injecting something optionally, but we weren't passing the optional injector flag.
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 10, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a call to
Injector.getin the date range input which is supposed to fall back tonullif the value doesn't resolve, however we're missing theOptionalflag. It works by accident at the moment, because the inject flags aren't actually being passed through by the framework.angular/angular#41592 is supposed to fix the framework issue, but their CI will break due to our usage.
These changes fix our usage in order to unblock the framework PR.