Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-checkbox): add larger touch target #22892

Merged
merged 1 commit into from
Jun 16, 2021
Merged

fix(material-experimental/mdc-checkbox): add larger touch target #22892

merged 1 commit into from
Jun 16, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 4, 2021

Sets up a larger touch target for checkboxes in order to meet the 48px minimum.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jun 4, 2021
@crisbeto crisbeto requested a review from mmalerba June 4, 2021 18:31
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2021
@crisbeto
fix(material-experimental/mdc-checkbox): add larger touch target
aa2e2f5 
Sets up a larger touch target for checkboxes in order to meet the 48px minimum.
@crisbeto crisbeto force-pushed the mdc-checkbox-touch-target branch from 704ab6c to aa2e2f5 Compare June 9, 2021 05:56
mmalerba
mmalerba approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 9, 2021
@jelbourn jelbourn mentioned this pull request Jun 16, 2021
Closed
@wagnermaciel wagnermaciel merged commit 437aba6 into angular:master Jun 16, 2021
wagnermaciel pushed a commit that referenced this pull request Jun 16, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-checkbox): add larger touch target (#22892
dee60fa 
)

Sets up a larger touch target for checkboxes in order to meet the 48px minimum.

(cherry picked from commit 437aba6)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jun 16, 2021
@crisbeto
fix(material-experimental/mdc-radio): add accessible touch targets
71ffaef 
Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in angular#22892.

Fixes angular#22991.
@crisbeto crisbeto mentioned this pull request Jun 16, 2021
Merged
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto
fix(material-experimental/mdc-radio): add accessible touch targets (#…
150d5af 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-radio): add accessible touch targets (#…
6074fd1 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

(cherry picked from commit 150d5af)
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-radio): add accessible touch targets (#…
041f582 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

(cherry picked from commit 150d5af)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @wagnermaciel