Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-select): resolve a couple of visual issues in high contrast mode #23007

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix(material-experimental/mdc-select): resolve a couple of visual issues in high contrast mode #23007

merged 1 commit into from
Jul 16, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 17, 2021 •
edited
Loading

  • Fixes that a small rectangle is rendered over the select placeholder text.
  • Fixes that the dropdown arrow wasn't visible.

For reference:
bug

@crisbeto
fix(material-experimental/mdc-select): resolve a couple of visual iss…
bd2b87e 
…ues in high contrast mode

* Fixes that a small rectangle is rendered over the select placeholder text.
* Fixes that the dropdown arrow wasn't visible.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jun 17, 2021
@crisbeto crisbeto requested a review from mmalerba June 17, 2021 16:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 17, 2021
@crisbeto crisbeto requested a review from andrewseguin June 29, 2021 18:35
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2021
@amysorto amysorto merged commit babfb21 into angular:master Jul 16, 2021
amysorto pushed a commit that referenced this pull request Jul 16, 2021
@crisbeto @amysorto
fix(material-experimental/mdc-select): resolve a couple of visual iss…
d112acb 
…ues in high contrast mode (#23007)

* Fixes that a small rectangle is rendered over the select placeholder text.
* Fixes that the dropdown arrow wasn't visible.

(cherry picked from commit babfb21)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @andrewseguin @amysorto