Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/autocomplete): don't emit optionActivated event when option is reset #23437

Merged
merged 1 commit into from
Sep 7, 2021
Merged

fix(material/autocomplete): don't emit optionActivated event when option is reset #23437

merged 1 commit into from
Sep 7, 2021

Conversation

crisbeto
Copy link
Member

Fixes that we were emitting the optionActivated event when the option is reset programmatically when the panel closes. The intent was to only emit the event as a result of a user action.

Fixes #23430.

@crisbeto
fix(material/autocomplete): don't emit optionActivated event when opt…
3db738a 
…ion is reset

Fixes that we were emitting the `optionActivated` event when the option is reset programmatically when the panel closes. The intent was to only emit the event as a result of a user action.

Fixes angular#23430.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Aug 24, 2021
@crisbeto crisbeto requested a review from jelbourn August 24, 2021 15:38
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 24, 2021
jelbourn
jelbourn approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2021
@zarend zarend merged commit 9a4a4cf into angular:master Sep 7, 2021
zarend pushed a commit that referenced this pull request Sep 7, 2021
@crisbeto @zarend
fix(material/autocomplete): don't emit optionActivated event when opt…
2a68fa8 
…ion is reset (#23437)

Fixes that we were emitting the `optionActivated` event when the option is reset programmatically when the panel closes. The intent was to only emit the event as a result of a user action.

Fixes #23430.

(cherry picked from commit 9a4a4cf)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatAutoComplete): optionActivated is invoked with the first item when ESC is pressed
3 participants
@crisbeto @jelbourn @zarend