Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/tabs): picking up mat-tab-label from child tabs #23560

Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix(material/tabs): picking up mat-tab-label from child tabs #23560

merged 1 commit into from
Sep 17, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 9, 2021

We use ContenChild to get a hold of the projected mat-tab-label inside a tab, but the problem is that this will also pick up label inside of nested tabs.

These changes add some safeguards so the labels don't get mixed up.

Fixes #23558.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 9, 2021
@crisbeto crisbeto requested a review from devversion September 9, 2021 20:03
@crisbeto crisbeto requested review from andrewseguin and a team as code owners September 9, 2021 20:03
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 9, 2021
@crisbeto
fix(material/tabs): picking up mat-tab-label from child tabs
21d610f 
We use `ContenChild` to get a hold of the projected `mat-tab-label` inside a tab, but the problem is that this will also pick up label inside of nested tabs.

These changes add some safeguards so the labels don't get mixed up.

Fixes angular#23558.
@crisbeto crisbeto force-pushed the 23558/tabs-nested-label branch from 946aa68 to 21d610f Compare September 9, 2021 20:26
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2021
@wagnermaciel wagnermaciel merged commit 505c0d1 into angular:master Sep 17, 2021
wagnermaciel pushed a commit that referenced this pull request Sep 17, 2021
@crisbeto @wagnermaciel
fix(material/tabs): picking up mat-tab-label from child tabs (#23560)
d256219 
We use `ContenChild` to get a hold of the projected `mat-tab-label` inside a tab, but the problem is that this will also pick up label inside of nested tabs.

These changes add some safeguards so the labels don't get mixed up.

Fixes #23558.

(cherry picked from commit 505c0d1)
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Tabs): Nested tabs with custom mat-tab-label template is wrongly applied to parent tab too
3 participants
@crisbeto @devversion @wagnermaciel