Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): VoiceOver reading out cell content twice #23563

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Adds a workaround to address the issue where VoiceOver reads out the content of the cells twice.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Sep 10, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2021
@crisbeto
Copy link
Member Author

Caretaker note: the changes in this PR are the optimal in terms of accessibility, but they have the potential to break tests where people were checking the textContent of calendar cells. There is an alternative approach that is backwards-compatible, but it offers a worse user experience. We should evaluate the approaches based on how difficult this is to land.

@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Sep 10, 2021
@crisbeto crisbeto force-pushed the voice-over-calendar-label branch from db631a9 to c29b1fd Compare September 10, 2021 05:16
@crisbeto crisbeto requested a review from a team as a code owner September 10, 2021 05:16
@devversion devversion removed the request for review from a team September 10, 2021 13:04
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this is an improvement over what's happening now, but I think we still have some more significant structural changes ahead of us to make the datepicker more usable (e.g., trying to move through the cells with VO navigation doesn't really work at all)

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 14, 2021
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto crisbeto force-pushed the voice-over-calendar-label branch from c29b1fd to ed3c80b Compare January 3, 2022 09:11
@crisbeto
Copy link
Member Author

crisbeto commented Jan 3, 2022

cc @zarend in case this overlaps with some of the datepicker work you've been doing.

Adds a workaround to address the issue where VoiceOver reads out the content of the cells twice.
@crisbeto crisbeto force-pushed the voice-over-calendar-label branch from ed3c80b to bed96ed Compare January 11, 2022 07:16
@zarend
Copy link
Contributor

zarend commented Jan 26, 2022

Hmm, I just tested on master, and I can't reproduce VoiceOver reading out a cell content twice. This might have been fixed by #24171

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Jan 27, 2022
@crisbeto
Copy link
Member Author

crisbeto commented Mar 8, 2022

Closing since it sounds like this was fixed.

@crisbeto crisbeto closed this Mar 8, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants