-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/datepicker): VoiceOver reading out cell content twice #23563
Conversation
Caretaker note: the changes in this PR are the optimal in terms of accessibility, but they have the potential to break tests where people were checking the |
db631a9
to
c29b1fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since this is an improvement over what's happening now, but I think we still have some more significant structural changes ahead of us to make the datepicker more usable (e.g., trying to move through the cells with VO navigation doesn't really work at all)
c29b1fd
to
ed3c80b
Compare
cc @zarend in case this overlaps with some of the datepicker work you've been doing. |
Adds a workaround to address the issue where VoiceOver reads out the content of the cells twice.
ed3c80b
to
bed96ed
Compare
Hmm, I just tested on master, and I can't reproduce VoiceOver reading out a cell content twice. This might have been fixed by #24171 |
Closing since it sounds like this was fixed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a workaround to address the issue where VoiceOver reads out the content of the cells twice.