Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/icon): add default options #23638

Merged
merged 1 commit into from
Feb 24, 2022
Merged

feat(material/icon): add default options #23638

merged 1 commit into from
Feb 24, 2022

Conversation

lekhmanrus
Copy link
Contributor

closes #23548

@lekhmanrus lekhmanrus requested review from jelbourn and a team as code owners September 24, 2021 21:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 24, 2021
@josephperrott josephperrott requested review from a team and removed request for a team September 27, 2021 16:22
jelbourn
jelbourn reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with this PR

@lekhmanrus lekhmanrus force-pushed the icon-default-options branch 2 times, most recently from 1933342 to 8eab99f Compare November 4, 2021 22:24
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@lekhmanrus lekhmanrus force-pushed the icon-default-options branch from 5dd4789 to 7cdbe17 Compare January 8, 2022 05:50
@lekhmanrus lekhmanrus requested a review from jelbourn January 8, 2022 05:51
@lekhmanrus lekhmanrus force-pushed the icon-default-options branch from 7cdbe17 to c39c842 Compare February 4, 2022 22:48
andrewseguin
andrewseguin reviewed Feb 17, 2022
View reviewed changes
@andrewseguin andrewseguin self-assigned this Feb 17, 2022
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 24, 2022
@andrewseguin andrewseguin merged commit 426afa0 into angular:master Feb 24, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 14, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(mat-icon): Create an injection token for setting icon-defaults
3 participants
@lekhmanrus @jelbourn @andrewseguin