Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: write pre-rendered univeral html file to bazel bin dir #23651

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

trik
Copy link
Contributor

@trik trik commented Sep 28, 2021

Server side rendered kitchen sync app was written inside the test sandbox execution directory, which is deleted after test execution when the is executed without --sandbox_debug option thus we couldn't retrieve the index-prendered.html file using the command echo $(bazel info bazel-bin)/src/universal-app/index-prerendered.html

@trik trik requested a review from devversion as a code owner September 28, 2021 11:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 28, 2021
@trik trik force-pushed the universal-prerender-output branch from 77d51a7 to 4b762cd Compare September 28, 2021 13:04
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Write server side pre-rendered kitchen sync app to bazel TEST_UNDECLARED_OUTPUTS_DIR.
Update the DEBUG guide information to retrieve the generated `index-prerendered.html`
@trik trik force-pushed the universal-prerender-output branch from 4b762cd to f549705 Compare September 28, 2021 13:38
@devversion devversion added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Sep 28, 2021
@amysorto amysorto merged commit 191bc92 into angular:master Sep 28, 2021
amysorto pushed a commit that referenced this pull request Sep 28, 2021
Write server side pre-rendered kitchen sync app to bazel TEST_UNDECLARED_OUTPUTS_DIR.
Update the DEBUG guide information to retrieve the generated `index-prerendered.html`

(cherry picked from commit 191bc92)
@trik trik deleted the universal-prerender-output branch September 30, 2021 10:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants