feat(material/core): change ErrorStateMatcher to accept AbstractForm #24012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Nov 25, 2021
…instead of FormControl
crisbeto
added
action: merge
devversion
approved these changes
Nov 27, 2021
|
@crisbeto At the moment, new features can only be merged with the "target: minor" or "target: major" label. Is it ok to change this to "target: minor"? |
crisbeto
added
target: minor
|
Yes, I've changed it to |
This was referenced Jan 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to use the
ErrorStateMatcheralso for determining the state ofFormGroups, I think the signature might be changed to acceptAbstractForminstead ofFormControl. The relevant properties are all part of theAbstractForm, so I don't expect any breaking behavior.