fix(material/datepicker): change calendar cell bodies to buttons (nesting buttons inside td approach) #24099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the structure of date cells to use buttons nested inside a gridcell. Previously the `td` tag would handle interaction, but this was problematic because Voiceover (and potentially other screenreaders) were not announcing that the gridcells were clickable bug angular#23476. Changes the DOM structure to nest a button role element inside the `td` and have the button handle interaction instead of the `td` Previous dom: ``` <td role="gridcell" tabindex="0" (click)="foo" ... > <div ...>...</div> </td> ``` Updated dom: ``` <td ... > <div role="button" tabindex="0" (click)="foo"...>...</div> </td> ``` Work in progress. fixes angular#23476
zarend
changed the title
zarend
changed the title
googlebot
added
the
cla: yes
|
closing in favor of #24171 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the structure of date cells to use buttons nested inside a
gridcell. Previously the
tdtag would handle interaction, but this wasproblematic because Voiceover (and potentially other screenreaders) were not announcing that the
gridcells were clickable bug #23476. Changes the DOM structure to nest a
button role element inside the
tdand have the button handleinteraction instead of the
tdPrevious dom:
Updated dom:
Work in progress.
fixes #23476