fix(cdk/overlay): fix positioning when zooming in Safari #24160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2022
Closed
jeripeierSBB
force-pushed
the
fix-safari-zoom
branch
from
e087608 to
3ea616e
Compare
crisbeto
reviewed
Jan 5, 2022
| // of the screen and to make space for the virtual keyboard. We need to account for this offset, | ||
| // otherwise our positioning will be thrown off. | ||
| // Additionally, when zooming in Safari this fixes the vertical position. | ||
| y -= containerRect.top; |
There was a problem hiding this comment.
Just to be on the safe side, shouldn't we check whether top is negative like we do above with left?
There was a problem hiding this comment.
I added the check. I did not add the check before since there was already no check when the expression was in the method _getExactOverlayY (there to fix virtual keyboard offset).
Currently, when zooming in Safari in macOS and iOS the overlay is positioned at the wrong place, offset by the zoom offset (left/top). This fix corrects this by adding/subtracting the corresponding offset.
jeripeierSBB
force-pushed
the
fix-safari-zoom
branch
from
3ea616e to
ea54c66
Compare
crisbeto
added
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Jan 6, 2022
Currently, when zooming in Safari in macOS and iOS the overlay is positioned at the wrong place, offset by the zoom offset (left/top). This fix corrects this by adding/subtracting the corresponding offset. (cherry picked from commit a6d21a1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when zooming in Safari in macOS and iOS the overlay is positioned
at the wrong place, offset by the zoom offset (left / top).
This fix corrects this by adding/subtracting the corresponding offset.
Screenshot in Safari 15.1 on macOS with activated zoom:
