Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/list): wrong order of arguments when calling custom compareWith function #24743

Merged
merged 2 commits into from
Apr 12, 2022
Merged

fix(material/list): wrong order of arguments when calling custom compareWith function #24743

merged 2 commits into from
Apr 12, 2022

Conversation

pweyrich
Copy link
Contributor

@pweyrich pweyrich commented Apr 6, 2022

Fixes a bug in Angular Material selection-list component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption.
Expected order based on documentation is:

  1. value of the respective option
  2. value of the selection

@pweyrich
fix(material/list): wrong order of arguments when calling custom comp…
84a181b 
…areWith function

Fixes a bug in Angular Material `selection-list` component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption.
Expected order based on documentation is:
1. value of the respective option
2. value of the selection
devversion
devversion reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems reasonable for now (Ideally I think the order would not be specified at all). We should do the same in the mdc-list. Could you please update that?

@pweyrich
Copy link
Contributor Author

pweyrich commented Apr 7, 2022

LGTM, seems reasonable for now (Ideally I think the order would not be specified at all). We should do the same in the mdc-list. Could you please update that?

Good point. I'll take care of it.

@pweyrich
fix(material-experimental/mdc-list): wrong order of arguments when ca…
553f013 
…lling custom compareWith function

Fixes a bug in Angular Material's experimental mdc-selection-list component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption.
Expected order based on documentation is:

1. value of the respective option
2. value of the selection
@pweyrich pweyrich requested a review from mmalerba as a code owner April 7, 2022 12:45
@pweyrich
Copy link
Contributor Author

pweyrich commented Apr 7, 2022

LGTM, seems reasonable for now (Ideally I think the order would not be specified at all). We should do the same in the mdc-list. Could you please update that?

@devversion done.

@devversion devversion added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Apr 7, 2022
@amysorto amysorto added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Apr 12, 2022
@amysorto amysorto merged commit fa12442 into angular:master Apr 12, 2022
amysorto pushed a commit that referenced this pull request Apr 12, 2022
@pweyrich @amysorto
fix(material/list): wrong order of arguments when calling custom comp…
aae6083 
…areWith function (#24743)

* fix(material/list): wrong order of arguments when calling custom compareWith function

Fixes a bug in Angular Material `selection-list` component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption.
Expected order based on documentation is:
1. value of the respective option
2. value of the selection

* fix(material-experimental/mdc-list): wrong order of arguments when calling custom compareWith function

Fixes a bug in Angular Material's experimental mdc-selection-list component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption.
Expected order based on documentation is:

1. value of the respective option
2. value of the selection

(cherry picked from commit fa12442)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 19, 2022
Update angularmaterial monorepo to v13.3.3 (#1306)
5653e42 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.2/13.3.3) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.2/13.3.3) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v13.3.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1333-tweed-table-2022-04-13)

[Compare Source](angular/components@13.3.2...13.3.3)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [949e3c7fbc](angular/components@949e3c7) | fix | **a11y:** visually hidden element affecting scrolling ([#&#8203;24620](angular/components#24620)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [1e010a3624](angular/components@1e010a3) | fix | **checkbox:** add the boolean property coercion for checked input ([#&#8203;20645](angular/components#20645)) |
| [6c65b1d703](angular/components@6c65b1d) | fix | **chips:** prevent default behavior on remove button ([#&#8203;24722](angular/components#24722)) |
| [4501b2518d](angular/components@4501b25) | fix | **datepicker:** avoid rerender when min/maxDate changes to different time on the same day ([#&#8203;24434](angular/components#24434)) |
| [aae60833eb](angular/components@aae6083) | fix | **list:** wrong order of arguments when calling custom compareWith function ([#&#8203;24743](angular/components#24743)) |
| [68c5e870bd](angular/components@68c5e87) | fix | **select:** empty space read out by VoiceOver on Chrome ([#&#8203;24741](angular/components#24741)) |
| [0d1755d566](angular/components@0d1755d) | fix | **snack-bar:** update generic types for openFromComponent ([#&#8203;24634](angular/components#24634)) |
| [b83d225b33](angular/components@b83d225) | fix | **tabs:** wrong scroll distance if selected tab is removed ([#&#8203;24118](angular/components#24118)) |
| [ca30f426a9](angular/components@ca30f42) | perf | **progress-bar:** do not run change detection if there are no `animationEnd` listeners ([#&#8203;24673](angular/components#24673)) |

#### Special Thanks

Artur Androsovych, Georgian Stan, Klemen Oslaj, Kristiyan Kostadinov, Michael Doner, Pascal Weyrich, Paul Gschwendtner, RobStrader and Zach Arend

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1306
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced Apr 22, 2022
Closed
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2022
@pweyrich pweyrich deleted the fix/selection-list/compareWith-onInit branch May 13, 2022 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pweyrich @devversion @amysorto