Add subheader and divider support to lists #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
|
||
| ```html | ||
| <md-list> | ||
| <md-subheader>Folders</md-subheader> |
There was a problem hiding this comment.
Did we not want to do something like
<h3 md-subheader> ... ?
I don't recall if we talked about doing this.
There was a problem hiding this comment.
Oh, now that you mention it, we did talk about it. I can update it to be an attribute selector.
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Nov 6, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 12, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 16, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 18, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
josephperrott
pushed a commit
that referenced
this pull request
Dec 18, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from #784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes #257
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 18, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
kseamon
pushed a commit
to kseamon/material2
that referenced
this pull request
Dec 18, 2024
- remove `overflow: hidden` that breaks TOC stickiness
- made sure to keep the Material Table examples from overflowing afterwards
via changes to `component-viewer.scss`
- revert change from angular#784 to make small breakpoint 939 instead of 959 as it
isn't consistent with our Sass breakpoints or the Material layout spec
- use alternative to `router-outlet + *` styling
- use constants for more media query breakpoints
- add some missing Sass imports
- move $sidenav-width to constants
- update constants to include different horizontal padding for
guides and sidenav content
- update copyright year
- add stylePreprocessorOptions for shorter Sass imports
- add .nvmrc since Angular projects only support NodeJS 12 atm
Fixes angular#257
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @jelbourn
Related: #107