fix(material/dialog): take dialog background from theme palette #26324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using MDC's `surface` variable to set the background of the dialog, however the `surface` was being mapped to our `card` variable. In practice the values for both are the same, but the new behavior breaks apps with custom palettes. Fixes angular#26272.
crisbeto
added
P3
devversion
approved these changes
Dec 25, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Feb 3, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.1.2/15.1.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.1.2/15.1.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.1.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1513-obsidian-organism-2023-02-02) [Compare Source](angular/components@15.1.2...15.1.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [d9124166a1](angular/components@d912416) | fix | **collections:** SelectionModel does not always respect the compareWith function ([#​26447](angular/components#26447)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [621d1755df](angular/components@621d175) | fix | **checkbox:** focus not moved to input when clicking on touch target ([#​26545](angular/components#26545)) | | [f1d83f19c9](angular/components@f1d83f1) | fix | **dialog:** take dialog background from theme palette ([#​26324](angular/components#26324)) | | [719cff0c4d](angular/components@719cff0) | fix | **tabs:** set color on disabled tabs ([#​26319](angular/components#26319)) | | [9efb60f6b4](angular/components@9efb60f) | fix | **tabs:** unable to click projected content in tab label ([#​26527](angular/components#26527)) | ##### google-maps | Commit | Type | Description | | -- | -- | -- | | [e48a5af71f](angular/components@e48a5af) | fix | error if API is initialized incorrectly ([#​26520](angular/components#26520)) | #### Special Thanks Alan Agius, Aurélien Loyer, Kristiyan Kostadinov, MECHERI Akram, Paul Gschwendtner, Pei Wang and Wagner Maciel <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjEyMC4wIn0=--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1768 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using MDC's
surfacevariable to set the background of the dialog, however thesurfacewas being mapped to ourcardvariable. In practice the values for both are the same, but the new behavior breaks apps with custom palettes.Fixes #26272.