Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button): fix ripple style for all types of buttons #26970

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

isantone
Copy link
Contributor

@isantone isantone commented Apr 21, 2023

The style for ripple were not added for mat-fab and mat-mini-fab buttons in #26568.
Spotting the issue on demo is a little bit tricky, because there are always a button (mat-button, mat-icon-button), which provides the global style for .mat-mdc-button-ripple. But without this components mat-fab button will look as on the screenshot below.

I was considering adding the overflow: hidden into fab.scss, but the _button-base.scss file is more appropriate in my opinion.

The ripple problem without overflow: hidden:
ripple-problem

@isantone isantone requested a review from andrewseguin as a code owner April 21, 2023 05:58
@google-cla
Copy link

google-cla bot commented Apr 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Apr 21, 2023
@angular-robot angular-robot bot merged commit 4e01b84 into angular:main Apr 21, 2023
angular-robot bot pushed a commit that referenced this pull request Apr 21, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants