Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cdk/drag-drop): fix cursor for disable drag #27286

Merged
merged 2 commits into from
Jun 13, 2023
Merged

docs(cdk/drag-drop): fix cursor for disable drag #27286

merged 2 commits into from
Jun 13, 2023

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Jun 13, 2023

fixes #27242

@naaajii naaajii requested a review from andrewseguin as a code owner June 13, 2023 06:46
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 13, 2023
crisbeto
crisbeto reviewed Jun 13, 2023
View reviewed changes
src/components-examples/cdk/drag-drop/cdk-drag-drop-disabled/cdk-drag-drop-disabled-example.css
@@ -25,7 +25,7 @@

.example-box.cdk-drag-disabled {
background: #ccc;
cursor: default;
cursor: not-allowed;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to also have user-select: none here since the original report also mentioned text selection.

crisbeto
crisbeto approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 13, 2023
@crisbeto crisbeto self-assigned this Jun 13, 2023
@crisbeto crisbeto merged commit ff7ea81 into angular:main Jun 13, 2023
crisbeto pushed a commit that referenced this pull request Jun 13, 2023
@naaajii @crisbeto
docs(cdk/drag-drop): fix cursor for disable drag (#27286)
b94a3bd 
* docs(cdk/drag-drop): fix cursor for disable drag

fixes #27242

* fixup! docs(cdk/drag-drop): fix cursor for disable drag

(cherry picked from commit ff7ea81)
crisbeto pushed a commit that referenced this pull request Jun 13, 2023
@naaajii @crisbeto
docs(cdk/drag-drop): fix cursor for disable drag (#27286)
6a64836 
* docs(cdk/drag-drop): fix cursor for disable drag

fixes #27242

* fixup! docs(cdk/drag-drop): fix cursor for disable drag

(cherry picked from commit ff7ea81)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2023
@naaajii naaajii deleted the fix-27242 branch September 27, 2024 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(CDK): The cursor should always be forbidden for dragging disabled items.
2 participants
@naaajii @crisbeto