fix(material/checkbox): Move unthemable tokens to theme mixin #27556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Aug 2, 2023
mmalerba
force-pushed
the
checkbox-unthemable-tokens
branch
from
c0809da to
6e7af74
Compare
mmalerba
added
target: minor
mmalerba
force-pushed
the
checkbox-unthemable-tokens
branch
2 times, most recently
from
3a4eb3c to
d62e635
Compare
mmalerba
added
target: major
Though these tokens are not currently affected by the theme, in the future they will be affected by the design system used for theming (M2 or M3) BREAKING CHANGE: There are new styles emitted by `mat.checkbox-theme` that are not emitted by any of: `mat.checkbox-color`, `mat.checkbox-typography`, `mat.checkbox-density`. If you rely on the partial mixins only and don't call `mat.checkbox-theme`, you can add `mat.checkbox-base` to get the missing styles.
mmalerba
force-pushed
the
checkbox-unthemable-tokens
branch
from
d62e635 to
ac7f3af
Compare
angular-robot
bot
added
the
detected: breaking change
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though these tokens are not currently affected by the theme, in the future they will be affected by the design system used for theming (M2 or M3)
BREAKING CHANGE:
There are new styles emitted by
mat.checkbox-themethat are notemitted by any of:
mat.checkbox-color,mat.checkbox-typography,mat.checkbox-density. If you rely on the partial mixins only and don'tcall
mat.checkbox-theme, you can addmat.checkbox-baseto get themissing styles.