fix(material/autocomplete): regression in requireSelection when options are filtered #28119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
…ns are filtered In angular#27781 the call to capture the input value was moved into the root of `_attachOverlay` in order to capture it even when there are no options. This is problematic, because `_attachOverlay` is called as the user is typing which basically breaks the `requireSelection` feature. These changes resolve the issue while preserving the original fix by only capturing the value when the overlay is actually attached. Fixes angular#28113.
crisbeto
force-pushed
the
28113/autocomplete-require-selection
branch
from
87bbae4 to
d534ae0
Compare
devversion
approved these changes
Nov 14, 2023
crisbeto
added a commit
that referenced
this pull request
Nov 14, 2023
…ns are filtered (#28119) In #27781 the call to capture the input value was moved into the root of `_attachOverlay` in order to capture it even when there are no options. This is problematic, because `_attachOverlay` is called as the user is typing which basically breaks the `requireSelection` feature. These changes resolve the issue while preserving the original fix by only capturing the value when the overlay is actually attached. Fixes #28113. (cherry picked from commit 13629b0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #27781 the call to capture the input value was moved into the root of
_attachOverlayin order to capture it even when there are no options. This is problematic, because_attachOverlayis called as the user is typing which basically breaks therequireSelectionfeature.These changes resolve the issue while preserving the original fix by only capturing the value when the overlay is actually attached.
Fixes #28113.