Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): always move caret to the end of the start input on backspace #28669

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 1, 2024

When the user presses backspace on an empty end input of a range picker, we move focus to the start input and assume that the caret will be at the end. It appears that in some cases the browser decides to move it to the beginning instead so these changes reuse the logic from the left/right arrow handling to explicitly move it to the end on backspace as well.

Fixes #28665.

…nput on backspace

When the user presses backspace on an empty end input of a range picker, we move focus to the start input and assume that the caret will be at the end. It appears that in some cases the browser decides to move it to the beginning instead so these changes reuse the logic from the left/right arrow handling to explicitly move it to the end on backspace as well.

Fixes angular#28665.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 1, 2024
@crisbeto crisbeto requested review from mmalerba and zarend as code owners March 1, 2024 09:09
@crisbeto crisbeto self-assigned this Mar 4, 2024
@crisbeto crisbeto removed request for zarend and mmalerba March 4, 2024 18:03
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2024
@crisbeto crisbeto merged commit fa2687f into angular:main Mar 4, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Mar 4, 2024
…nput on backspace (#28669)

When the user presses backspace on an empty end input of a range picker, we move focus to the start input and assume that the caret will be at the end. It appears that in some cases the browser decides to move it to the beginning instead so these changes reuse the logic from the left/right arrow handling to explicitly move it to the end on backspace as well.

Fixes #28665.

(cherry picked from commit fa2687f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Range picker issue
2 participants