Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/form-field): ensure same stacking context as container #28713

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 12, 2024

When will-change was removed in #27251, the form field lost its implicit stacking context which means that some of its descendants may be stacked on top of the container.

These changes add an explicit z-index on the container to resolve the issue.

Fixes #28708.

@crisbeto crisbeto added the target: rc This PR is targeted for the next release-candidate label Mar 12, 2024
When `will-change` was removed in angular#27251, the form field lost its implicit stacking context which means that some of its descendants may be stacked on top of the container.

These changes add an explicit `z-index` on the container to resolve the issue.

Fixes angular#28708.
@crisbeto crisbeto force-pushed the 28708/form-field-stacking branch from 4fe3424 to 79976f2 Compare March 12, 2024 11:47
@crisbeto crisbeto removed the request for review from mmalerba March 12, 2024 17:16
@crisbeto crisbeto self-assigned this Mar 12, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2024
@crisbeto crisbeto merged commit ce9a395 into angular:main Mar 12, 2024
24 of 26 checks passed
crisbeto added a commit that referenced this pull request Mar 12, 2024
…28713)

When `will-change` was removed in #27251, the form field lost its implicit stacking context which means that some of its descendants may be stacked on top of the container.

These changes add an explicit `z-index` on the container to resolve the issue.

Fixes #28708.

(cherry picked from commit ce9a395)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatFormField): Resetting will-change breaks stacking context when sticky columns are used with MatTable
2 participants