Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiple): set nonce using setAttribute #28800

Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix(multiple): set nonce using setAttribute #28800

merged 1 commit into from
Apr 1, 2024

Conversation

crisbeto
Copy link
Member

Uses setAttribute to set the nonce, instead of DOM property in order to work properly in SSR.

Fixes #28780.

@crisbeto
fix(multiple): set nonce using setAttribute
2d55ed3 
Uses `setAttribute` to set the nonce, instead of DOM property in order to work properly in SSR.

Fixes angular#28780.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 30, 2024
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 30, 2024 08:01
@crisbeto crisbeto requested a review from mmalerba March 30, 2024 17:02
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 1, 2024
@crisbeto crisbeto merged commit 452cde2 into angular:main Apr 1, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Apr 1, 2024
@crisbeto
fix(multiple): set nonce using setAttribute (#28800)
6b5b0c5 
Uses `setAttribute` to set the nonce, instead of DOM property in order to work properly in SSR.

Fixes #28780.

(cherry picked from commit 452cde2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Layout): createEmptyStyleRule not adding nonce correctly in Chrome
2 participants
@crisbeto @wagnermaciel