fix(material/menu): remove dependency on NgClass #28877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can set classes directly through `[class]` instead of having to import `NgClass`. I had to adjust the code a bit, because the built-in `[class]` binding doesn't do diffing on the object literal.
|
hi @crisbeto , why are you doing these PRs removing ngClass? It's a bad practice to use it? Should we always use [class] instead? |
|
I wouldn't say it's a bad practice, I'm just cleaning up the places where we can get away with the simpler binding and to reduce the number of dependencies. |
wagnermaciel
approved these changes
Apr 15, 2024
crisbeto
added a commit
that referenced
this pull request
Apr 15, 2024
We can set classes directly through `[class]` instead of having to import `NgClass`. I had to adjust the code a bit, because the built-in `[class]` binding doesn't do diffing on the object literal. (cherry picked from commit 9381f90)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set classes directly through
[class]instead of having to importNgClass. I had to adjust the code a bit, because the built-in[class]binding doesn't do diffing on the object literal.