Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple): change fallbacks to use m3 #29528

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(multiple): change fallbacks to use m3 #29528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/material/core/_core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@

// Mixin that renders all of the core styles that are not theme-dependent.
@mixin core() {
// TODO: Move ripple styles to be dynamically loaded instead of in core.
// This variable is used as a fallback for the ripple element's
// background color. However, if it isn't defined anywhere, then MSS
// complains in its verification stage.
html {
--mat-app-on-surface: initial;
}

@include ripple.ripple();
@include cdk.a11y-visually-hidden();
@include cdk.overlay();
Expand Down
6 changes: 1 addition & 5 deletions src/material/core/tokens/_token-utils.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,7 @@ $_system-fallbacks: m3-tokens.create-system-fallbacks();
@return _create-var($sys-fallback, $fallback);
}

// TODO(mat-app-theme): Return the system-level fallback.
// Changing this will affect clients that do not properly call theme mixins since the tokens
// will be undefined and now default to M3 system values, causing a number of screenshot failures.
// @return $sys-fallback;
@return $fallback;
@return $sys-fallback;
}

// Outputs a map of tokens under a specific prefix.
Expand Down
Loading