Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove usages of CommonModule in the dev app #29869

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

crisbeto
Copy link
Member

CommonModule was being used primarily for the control flow directives which have been replaced by the built-in control flow syntax. These changes either remove it or replace it with importing the individual symbols.

`CommonModule` was being used primarily for the control flow directives which have been replaced by the built-in control flow syntax. These changes either remove it or replace it with importing the individual symbols.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 12, 2024
@crisbeto crisbeto requested a review from devversion October 12, 2024 07:26
@crisbeto crisbeto requested a review from a team as a code owner October 12, 2024 07:26
@crisbeto crisbeto requested review from andrewseguin and removed request for a team October 12, 2024 07:26
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 12, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 13, 2024
@crisbeto crisbeto removed the request for review from andrewseguin October 13, 2024 17:19
@crisbeto crisbeto merged commit fe4271f into angular:main Oct 13, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Oct 13, 2024
`CommonModule` was being used primarily for the control flow directives which have been replaced by the built-in control flow syntax. These changes either remove it or replace it with importing the individual symbols.

(cherry picked from commit fe4271f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants