fix(material/autocomplete): switch away from animations module #30356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the autocomplete away from the animations module. The animations are implemented using CSS instead.
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
crisbeto
commented
Jan 20, 2025
| } | ||
| } | ||
|
|
||
| // Note: the autocomplete intentionally only implements an enter animation. |
There was a problem hiding this comment.
I decided to do this, because the autocomplete is quite jumpy on selection at the moment and implementing the exit animation requires some extra code.
andrewseguin
approved these changes
Jan 21, 2025
crisbeto
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the autocomplete away from the animations module. The animations are implemented using CSS instead.