Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/select): fixed text color for selected options in multiple select #30367

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix(material/select): fixed text color for selected options in multiple select #30367

merged 2 commits into from
Jan 27, 2025

Conversation

AJJPostma
Copy link
Contributor

@AJJPostma AJJPostma commented Jan 22, 2025 •
edited
Loading

Fixes a bug in the Angular Material select component where the selected options in a select with the multiple attribute have the wrong text color. This is because the the text color styling for the select without the multiple attribute is applied.

fixes #30366

@AJJPostma AJJPostma requested a review from a team as a code owner January 22, 2025 11:24
@AJJPostma AJJPostma requested review from crisbeto and amysorto and removed request for a team January 22, 2025 11:24
@AJJPostma AJJPostma changed the title fixed text color for selected options in multiple select fix(material/select): fixed text color for selected options in multiple select Jan 22, 2025
@crisbeto crisbeto removed the request for review from amysorto January 24, 2025 07:43
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 24, 2025
@crisbeto crisbeto merged commit 11f02ee into angular:main Jan 27, 2025
11 checks passed
@crisbeto
Copy link
Member

The changes were merged into the following branches: main, 19.1.x

crisbeto pushed a commit that referenced this pull request Jan 27, 2025
@AJJPostma @crisbeto
fix(material/select): fixed text color for selected options in multip…
4a96a25 
…le select (#30367)

* fixed text color for selected options in multiple select

* added change to comment

(cherry picked from commit 11f02ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(select): multiple select uses single select text color for selected options (on-secondary-container)
2 participants
@AJJPostma @crisbeto