Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/text-field): auto sizing broken if user styles stretch the element #30412

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(cdk/text-field): auto sizing broken if user styles stretch the element #30412

merged 1 commit into from
Jan 29, 2025

Conversation

crisbeto
Copy link
Member

Fixes that our logic for measuring the textarea was being thrown off by user code that stretches it out.

@crisbeto
fix(cdk/text-field): auto sizing broken if user styles stretch the el…
f977be9 
…ement

Fixes that our logic for measuring the `textarea` was being thrown off by user code that stretches it out.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 29, 2025
@crisbeto crisbeto requested a review from a team as a code owner January 29, 2025 11:23
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team January 29, 2025 11:23
@crisbeto crisbeto added the G This is is related to a Google internal issue label Jan 29, 2025
@crisbeto crisbeto requested a review from andrewseguin January 29, 2025 12:07
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2025
@crisbeto crisbeto merged commit 73022d8 into angular:main Jan 29, 2025
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Jan 29, 2025
@crisbeto
fix(cdk/text-field): auto sizing broken if user styles stretch the el…
c1a3cae 
…ement (#30412)

Fixes that our logic for measuring the `textarea` was being thrown off by user code that stretches it out.

(cherry picked from commit 73022d8)
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/text-field G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @wagnermaciel