datepicker: create injectable for date formats and bundle it along with date adapter into MdNativeDateModule #4296
Conversation
googlebot
added
the
cla: yes
| @@ -95,7 +107,8 @@ export class MdCalendar<D> implements AfterContentInit { | |||
| /** The label for the current calendar view. */ | |||
| get _periodButtonText(): string { | |||
| return this._monthView ? | |||
| this._dateAdapter.getMonthYearName(this._activeDate, 'short').toLocaleUpperCase() : | |||
| this._dateAdapter.format(this._activeDate, this._dateFormats.display.monthYearLabel) | |||
| .toLocaleUpperCase() : | |||
There was a problem hiding this comment.
Shouldn't the upper-casing be part of what the formatter does?
There was a problem hiding this comment.
I don't think either the format language used by Intl.DatetimeFormat or Moment.js gives control over the case, so we're stuck doing this
|
@mmalerba anything else missing before merging into master? |
|
@fxck This was the last major feature, all I have left to do is make sure it works well on different browsers and screen readers. |
|
Ok, cool. I tried c&p it into my project and fixing the paths meanwhile, looks like there are some problems with it not being rebased as well.
// edit nevermind, caused by changes to input container that are not in master |
…th date adapter into MdNativeDateModule (#4296) * New module structure for DateAdapter. * pass through format options * move date-formats to core/datetime * don't subclass error * add test for missing providers case
|
I just rebased it, give it another try |
|
It wasn't the problem in the end, underlineRef currently not existing on input container on current master was. I've changed it to elementRef instead for now. // edit
Got it! Almost. :D My global |
|
@mmalerba do you have any screenshots of how the datetimepicker will look? Got it running fine now. |
…th date adapter into MdNativeDateModule (#4296) * New module structure for DateAdapter. * pass through format options * move date-formats to core/datetime * don't subclass error * add test for missing providers case
…th date adapter into MdNativeDateModule (#4296) * New module structure for DateAdapter. * pass through format options * move date-formats to core/datetime * don't subclass error * add test for missing providers case
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.