Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(): Remove main method wrapper from all test files #494

Merged
merged 2 commits into from
May 23, 2016
Merged

test(): Remove main method wrapper from all test files #494

merged 2 commits into from
May 23, 2016

Conversation

trik
Copy link
Contributor

@trik trik commented May 22, 2016

Closes #480

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2016
@devversion
Copy link
Member

You should also remove the entry-point of the tests in the shim file.

@trik
Copy link
Contributor Author

trik commented May 23, 2016

removed the check in the shim file. the number of tests executed remains the same

Chrome 50.0.2661 (Mac OS X 10.11.4): Executed 187 of 187 SUCCESS (5.439 secs / 5.395 secs)

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit e8cf256 into angular:master May 23, 2016
@jelbourn
Copy link
Member

Thanks!

@trik trik deleted the remove-main branch May 23, 2016 17:26
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove main method wrapper from all test files.
4 participants