-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make material work with noUnusedParameters #4946
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ export class ScrollDispatcher { | |
getScrollContainers(elementRef: ElementRef): Scrollable[] { | ||
const scrollingContainers: Scrollable[] = []; | ||
|
||
this.scrollableReferences.forEach((subscription: Subscription, scrollable: Scrollable) => { | ||
this.scrollableReferences.forEach((_subscription: Subscription, scrollable: Scrollable) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately there is no |
||
if (this.scrollableContainsElement(scrollable, elementRef)) { | ||
scrollingContainers.push(scrollable); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need an underscore? I'd prefer not to use
_
for function arguments; is TS not smart enough to know that you've included an argument so that you can have access to a subsequent one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah unfortunately it's smart enough do detect this