Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default gulp task should not list tasks #5935

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

devversion
Copy link
Member

  • The default gulp task should not list all gulp tasks. This a way too long list with all internal things as well.
  • Addresses feedback from @jelbourn in Flex-Layout's tooling sync PR.

@jelbourn The change of the NPM version shouldn't really have any value, but it may re-validate the cache of NPM and it's also more explicit.

* The default gulp task should not list all gulp tasks. This a way too long list with all internal things as well.
* Addresses feedback from @jelbourn in Flex-Layout's tooling sync PR.
@devversion devversion requested a review from jelbourn as a code owner July 21, 2017 10:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 21, 2017
@kara kara merged commit 957b8fd into angular:master Jul 21, 2017
@devversion devversion deleted the chore/default-gulp-task-list branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants