Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(tabs): fix arrows not showing on reszize #6303 #6304

Merged
merged 4 commits into from
Aug 9, 2017
Merged

bug(tabs): fix arrows not showing on reszize #6303 #6304

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b185eac
bug(tabs): fix arrows not showing on reszize #6303
amcdnl Aug 6, 2017
b84092c
chore(*): update to use host vs hostliener
amcdnl Aug 6, 2017
68e6ddd
bug(tabs): address feedback in pr
amcdnl Aug 7, 2017
a792f6e
bug(tabs): address PR feedback
amcdnl Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib/tabs/tab-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
Renderer2,
ChangeDetectionStrategy,
ChangeDetectorRef,
HostListener
} from '@angular/core';
import {
RIGHT_ARROW,
Expand Down Expand Up @@ -79,6 +80,7 @@ export const _MdTabHeaderMixinBase = mixinDisableRipple(MdTabHeaderBase);
'class': 'mat-tab-header',
'[class.mat-tab-header-pagination-controls-enabled]': '_showPaginationControls',
'[class.mat-tab-header-rtl]': "_getLayoutDirection() == 'rtl'",
'(window:resize)': "_checkPaginationEnabled()"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least this call should be debounced. The comment for the handler even says "This is an expensive call that forces a layout reflow to compute box and scroll metrics and should be called sparingly."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really just have one library-wide resize handler instead of each component adding their own. Add a TODO?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to add a unit test for this?

}
})
export class MdTabHeader extends _MdTabHeaderMixinBase
Expand Down